Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashValues - don't copy arrays #1377

Merged
merged 3 commits into from
Nov 3, 2020
Merged

hashValues - don't copy arrays #1377

merged 3 commits into from
Nov 3, 2020

Conversation

PabstMirror
Copy link
Contributor

Co-Authored-By: commy2 6576312+commy2@users.noreply.github.com

Without fix it will fail this test case

_data pushBack [7];
TEST_OP(_values,isEqualTo,[[ARR_2(3,[7])]],"hashValues - deep array copy");

[CBA] (hashes) ERROR: Test FAIL x\cba\addons\hashes\test_hashes.sqf:154
             (_values isEqualTo [[3, [7]]])

@PabstMirror @commy2
hashValues - don't copy arrays
0084621 
Co-Authored-By: commy2 <6576312+commy2@users.noreply.github.com>
@PabstMirror PabstMirror added this to the 3.15.2 milestone Oct 13, 2020
@PabstMirror @commy2
Update addons/hashes/fnc_hashValues.sqf
4b2f72b 
Co-authored-by: commy2 <commy-2@gmx.de>
@jokoho48
Copy link
Member

hashKeys should also changed to have the same behaviour

@PabstMirror PabstMirror merged commit 311e599 into master Nov 3, 2020
@PabstMirror PabstMirror deleted the hashArrayDeep branch November 3, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
3.15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @jokoho48 @commy2